block ids and tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the treatments assigned removed unused variable replaced code by simple pandas ngroup call no more inplace operations added test to check the right number of block ids was returned minor syntax change assigned column and drop old one added a block id to the return df to retrieve within which blocks the treatments were assigned added blank line at end of test file added a block id to the return df to retrieve within which blocks were the treatments assigned, added testing to check the number of ids produced moved sorting after all checks are done, and replaced syntax for filtering on columns to avoid problems if input has column named 'block' added a block id to the return df to retrieve within which blocks were the treatments assigned, added corresponding tests, moved sorting after all checks are done, and replaced syntax for filtering on columns to avoid problems if input has column named 'block'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of the tests are currently failing, which is because the treatment assignment shares just aren't right. Still valuable to have tests against that.