Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hdf5 pin #36975

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Remove hdf5 pin #36975

merged 10 commits into from
Apr 2, 2024

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Mar 5, 2024

Description of work

Update to v1.14 of HDF5. This will allow us to move to newer versions of other packages, e.g. boost and libcurl.

Upgrading HDF5 has also enabled the removal of some other pinnings to secondary dependencies (icu, libxml2, openssl) that were originally applied to prevent conda env resolution issues when building the mantidqt package.

Fixes #36974
Fixes #36489

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson
Copy link
Member

We could move to cmake v3.28.4 if you don't care about win32. v3.29.0 if you don't care about osx-arm64.

@peterfpeterson
Copy link
Member

For some reason, the conda package build is using the 5y old package rather than the one from this week.

conda-forge file list

@peterfpeterson peterfpeterson marked this pull request as ready for review March 28, 2024 19:26
@SilkeSchomann SilkeSchomann merged commit 2daa855 into main Apr 2, 2024
9 checks passed
@SilkeSchomann SilkeSchomann deleted the 36974_unpin_hdf5 branch April 2, 2024 06:42
peterfpeterson added a commit to peterfpeterson/mantid that referenced this pull request Apr 2, 2024
This is a version of mantidproject#36975 into `ornl-next`. It also includes
updating pre-commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update hdf5 Unpin openssl
4 participants