[core] applied PR review changes

mantinedev · Oct 1, 2023 · ad0502b · ad0502b
1 parent bbb68d6
commit ad0502b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 19 deletions.
diff --git a/src/mantine-core/src/components/Spoiler/Spoiler.module.css b/src/mantine-core/src/components/Spoiler/Spoiler.module.css
@@ -1,8 +1,9 @@
 .root {
   position: relative;
+  margin-bottom: var(--_spoiler-margin-bottom);
 
   &[data-has-spoiler] {
-    margin-bottom: var(--spoiler-margin-bottom, rem(24px));
+    --_spoiler-margin-bottom: rem(24px);
   }
 }
 

diff --git a/src/mantine-core/src/components/Spoiler/Spoiler.tsx b/src/mantine-core/src/components/Spoiler/Spoiler.tsx
@@ -11,15 +11,13 @@ import {
   createVarsResolver,
   Factory,
   rem,
-  getSpacing,
-  MantineSpacing,
 } from '../../core';
 import { Anchor } from '../Anchor';
 import classes from './Spoiler.module.css';
 
 export type SpoilerStylesNames = 'root' | 'control' | 'content';
 export type SpoilerCssVariables = {
-  root: '--spoiler-transition-duration' | '--spoiler-margin-bottom';
+  root: '--spoiler-transition-duration';
 };
 
 export interface SpoilerProps
@@ -43,9 +41,6 @@ export interface SpoilerProps
 
   /** Spoiler reveal transition duration in ms, set 0 or null to turn off animation, `200` by default */
   transitionDuration?: number;
-
-  /** Margin bottom applied when the control button is shown, `rem(24px)` by default */
-  activeSpoilerMarginBottom?: MantineSpacing;
 }
 
 export type SpoilerFactory = Factory<{
@@ -60,16 +55,12 @@ const defaultProps: Partial<SpoilerProps> = {
   initialState: false,
 };
 
-const varsResolver = createVarsResolver<SpoilerFactory>(
-  (_, { transitionDuration, activeSpoilerMarginBottom }) => ({
-    root: {
-      '--spoiler-transition-duration':
-        transitionDuration !== undefined ? `${transitionDuration}ms` : undefined,
-      '--spoiler-margin-bottom':
-        activeSpoilerMarginBottom !== undefined ? getSpacing(activeSpoilerMarginBottom) : undefined,
-    },
-  })
-);
+const varsResolver = createVarsResolver<SpoilerFactory>((_, { transitionDuration }) => ({
+  root: {
+    '--spoiler-transition-duration':
+      transitionDuration !== undefined ? `${transitionDuration}ms` : undefined,
+  },
+}));
 
 export const Spoiler = factory<SpoilerFactory>((_props, ref) => {
   const props = useProps('Spoiler', defaultProps, _props);

diff --git a/src/mantine-styles-api/src/data/Spoiler.styles-api.ts b/src/mantine-styles-api/src/data/Spoiler.styles-api.ts
@@ -11,8 +11,6 @@ export const SpoilerStylesApi: StylesApiData<SpoilerFactory> = {
   vars: {
     root: {
       '--spoiler-transition-duration': 'Controls transition duration',
-      '--spoiler-margin-bottom':
-        'Controls the margin bottom applied when the control button is shown',
     },
   },
-Original file line number
+Diff line change
@@ Expand Up @@
       vars: {
         root: {
           '--spoiler-transition-duration': 'Controls transition duration',
-          '--spoiler-margin-bottom':
-            'Controls the margin bottom applied when the control button is shown',
         },
       },
@@ Expand Down @@