Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/dates]: DateTimePicker minTime & maxTime fix #4900

Closed
wants to merge 2 commits into from

Conversation

ShaifArfan
Copy link
Contributor

Possible fix for #4596

@rtivital
Copy link
Member

rtivital commented Oct 1, 2023

It does not work. When min date is set, it is impossible to enter any time if selected date is min or max date. If date is between min and max dates it is impossible to enter minutes.

2023-10-01.15.15.27.mov

Story:

export function WithTimeMinMaxDate() {
  return (
    <div style={{ padding: 40, maxWidth: 400 }}>
      <DateTimePicker
        placeholder="Date time picker"
        defaultValue={new Date(2022, 3, 11)}
        clearable
        minDate={new Date(2022, 3, 10, 10, 50)}
        maxDate={new Date(2022, 3, 12, 10, 50)}
      />
    </div>
  );
}

@rtivital rtivital added the Invalid Incorrect issue or PR label Oct 1, 2023
@rtivital rtivital closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Incorrect issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants