New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] Switch: fix accessibility V6 #5755

Merged

rtivital merged 1 commit into mantinedev:v6 from ocshawn:fix-switch-accessibility-backportToV6

Feb 26, 2024

Contributor

ocshawn commented Feb 12, 2024 •

edited

Loading

Fixes #5699.

Backport of #5746

Things to note:

Due to the implementation of role="switch", some tests needed to be adjusted.
Screen readers no longer read out the onLabel and offLabel values, however I consider this to be appropriate as the label or aria-label should be used to provide enough context that these values are not needed.
Screen reader testing was conducted across ChromeVox and Ubuntu Orca.
Open to suggestions on types for bodyElement and labelElement.


          [@mantine/core] Switch: fix accessibility

54b5c56

rtivital merged commit 311a893 into mantinedev:v6

1 check passed

Member

rtivital commented Feb 26, 2024

Thanks!

ocshawn deleted the fix-switch-accessibility-backportToV6 branch

March 4, 2024 15:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet