Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] SegmentControl: Fix design inconsistencies when used within a modal #5876

Closed
wants to merge 9 commits into from
Closed

[@mantine/core] SegmentControl: Fix design inconsistencies when used within a modal #5876

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42759f1
[@mantine/core] Combobox: Add onClose prop to Combobox component
ID-JA Jan 3, 2024
615db31
call both close handlers
ID-JA Jan 5, 2024
3f3dd55
undo formatting
ID-JA Jan 5, 2024
1b552a6
format code
ID-JA Jan 5, 2024
d553a7f
Refactor Combobox component to use onDropdownClose callback
ID-JA Jan 5, 2024
8b992a5
Merge branch 'mantinedev:master' into master
ID-JA Mar 5, 2024
67b0481
Fix: `SegmentedControl` design breaks when inside a modal
ID-JA Mar 6, 2024
cbbd8e9
remove unused code
ID-JA Mar 6, 2024
620f5c5
remove unused code
ID-JA Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@mantine/core/src/components/SegmentedControl/SegmentedControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ export const SegmentedControl = factory<SegmentedControlFactory>((_props, ref) =
const element = refs.current[_value];
if (element) {
const rootPadding = getRootPadding(rootRef.current!, WRAPPER_PADDING);
const elementRect = element.getBoundingClientRect();
const scaledValue = element.offsetWidth / elementRect.width;
const scaledValue = element.offsetWidth / element.clientWidth;
const width = element.clientWidth * scaledValue || 0;
const height = element.clientHeight * scaledValue || 0;

Expand Down
Loading