Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] fix: ensure TagsInput dropdown reopens after clearing #6207

Closed
wants to merge 1 commit into from

Conversation

hsskey
Copy link
Contributor

@hsskey hsskey commented May 9, 2024

Fix: Resolve the issue where the TagsInput dropdown would not reopen after clearing tags.


This PR addresses the issue where the dropdown of the TagsInput component fails to reopen after the user clicks the clear button and subsequently attempts to interact with the input again.

Problem:
The dropdown, after tags are cleared via the clear button, remains closed upon subsequent interactions unless clicked outside and back again. This behavior was consistent across all browsers and was problematic from a UX perspective.

Solution:
A modification was made to the PillsInput component's click event logic. Now, the dropdown checks if there are any items in the parsedData array (ensuring there are actionable items) before deciding to open. This change ensures that the dropdown reopens as expected when there are items available to display, thus improving the component's usability.

fixes #6115
commit: 3a43d08

@hsskey hsskey closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearable TagsInput does not show dropdown after clearing
1 participant