MANTINE-6336: Fix DateInput to setInputValue to _value which has time zone applied #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio16T
changed the title
|
Thanks! |
This was referenced Sep 12, 2024
This was referenced Sep 19, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6336
Reviewed code and discovered that the useDidUpdate hook was not setting the state value with timezone when applicable.
Before: It was running and setting the inputValue to the initial onChange Value without applying the updates from the useUncontrolledDates Hook.
After: _value is the source of truth to display in input and will display with updates applied by useUncontrolledDates Hook.