Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]-[fee]fix: fix estimateGas; discard invalid tx #67

Merged
merged 17 commits into from
Mar 13, 2024
Merged

[R4R]-[fee]fix: fix estimateGas; discard invalid tx #67

merged 17 commits into from
Mar 13, 2024

Conversation

Tri-stone
Copy link

@Tri-stone Tri-stone commented Mar 12, 2024 •
edited
Loading

Core changes:

  • discard invalid tx after commitTransaction, refer to go-ethereum
  • fix the case gasPrice = 0 when estimateGas
  • gasLimit should cover l1Cost when validating in txpool
  • fix l1Cost when replacing tx in txpool, refer to code

@Tri-stone Tri-stone changed the title [R4R]-[txpool]fix: discard invalid tx [WIP]-[txpool]fix: discard invalid tx Mar 12, 2024
@Tri-stone Tri-stone changed the title [WIP]-[txpool]fix: discard invalid tx [WIP]-[miner]fix: discard invalid tx Mar 12, 2024
asdv23
asdv23 previously approved these changes Mar 12, 2024
View reviewed changes
@asdv23 asdv23 self-requested a review March 12, 2024 09:42
@Tri-stone Tri-stone changed the title [WIP]-[miner]fix: discard invalid tx [R4R]-[fee]fix: discard invalid tx Mar 13, 2024
@Tri-stone Tri-stone changed the title [R4R]-[fee]fix: discard invalid tx [R4R]-[fee]fix: fix estimateGas; discard invalid tx Mar 13, 2024
@Tri-stone Tri-stone changed the title [R4R]-[fee]fix: fix estimateGas; discard invalid tx [WIP]-[fee]fix: fix estimateGas; discard invalid tx Mar 13, 2024
Sha3nS
Sha3nS previously approved these changes Mar 13, 2024
View reviewed changes
abelliumnt
abelliumnt reviewed Mar 13, 2024
View reviewed changes
core/txpool/txpool.go Outdated Show resolved Hide resolved
abelliumnt
abelliumnt reviewed Mar 13, 2024
View reviewed changes
core/txpool/txpool.go Outdated Show resolved Hide resolved
@Tri-stone Tri-stone changed the title [WIP]-[fee]fix: fix estimateGas; discard invalid tx [R4R]-[fee]fix: fix estimateGas; discard invalid tx Mar 13, 2024
@Tri-stone Tri-stone merged commit 4d49b52 into release/v1.0.0 Mar 13, 2024
2 checks passed
Tri-stone added a commit that referenced this pull request Apr 28, 2024
@Tri-stone
[R4R]-[fee]fix: fix estimateGas; discard invalid tx (#67)
c7487d3
This was referenced Apr 28, 2024
Merged
Merged
@Tri-stone Tri-stone deleted the leo/fix_validate_txpool branch April 28, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-xu-mantle adam-xu-mantle adam-xu-mantle approved these changes

@Sha3nS Sha3nS Sha3nS approved these changes

@abelliumnt abelliumnt abelliumnt approved these changes

@asdv23 asdv23 Awaiting requested review from asdv23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tri-stone @abelliumnt @Sha3nS @asdv23 @adam-xu-mantle