You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JsonSubTypes, as a library, should have dependency on Newtonsoft.Json set to minimum supported version, not whatever version is currently latest.
Setting dependency to older version doesn't mean that application will run with outdated version of Newtonsoft.Json, it just means constraint which should be met during version resolution..
It would give users flexibility of choice.
For example, if JsonSubTypes used in another library, which doesn't have explicit requirement on version of Newtonsoft.Json, but since JsonSubTypes enforces latest version, that library has to enforce it too.
The current version 1.7.0 depend on Newtonsoft.Json version 12.0.3 its code can compile from including version 10.0.1 . The tests need at least version 12.0.1 for (#80):
Thanks!. The test project is an example of host application in this case which can perfectly reference a later version of Newtonsoft.Json package than JsonSubTypes does.
JsonSubTypes, as a library, should have dependency on Newtonsoft.Json set to minimum supported version, not whatever version is currently latest.
Setting dependency to older version doesn't mean that application will run with outdated version of Newtonsoft.Json, it just means constraint which should be met during version resolution..
It would give users flexibility of choice.
For example, if JsonSubTypes used in another library, which doesn't have explicit requirement on version of Newtonsoft.Json, but since JsonSubTypes enforces latest version, that library has to enforce it too.
Related: #41
The text was updated successfully, but these errors were encountered: