Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonsoft.Json dependency version should be lowest supported, not latest available #101

Closed
kostrse opened this issue Apr 29, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@kostrse
Copy link

kostrse commented Apr 29, 2020

JsonSubTypes, as a library, should have dependency on Newtonsoft.Json set to minimum supported version, not whatever version is currently latest.

Setting dependency to older version doesn't mean that application will run with outdated version of Newtonsoft.Json, it just means constraint which should be met during version resolution..

It would give users flexibility of choice.

For example, if JsonSubTypes used in another library, which doesn't have explicit requirement on version of Newtonsoft.Json, but since JsonSubTypes enforces latest version, that library has to enforce it too.

Related: #41

@manuc66
Copy link
Owner

manuc66 commented May 1, 2020

Hi,

The current version 1.7.0 depend on Newtonsoft.Json version 12.0.3 its code can compile from including version 10.0.1 . The tests need at least version 12.0.1 for (#80):

NamingStrategy = new SnakeCaseNamingStrategy()

A bugfix release can be envisioned to lower the dependency down to 10.0.1.

@manuc66 manuc66 self-assigned this May 1, 2020
@manuc66 manuc66 added the bug label May 1, 2020
@manuc66 manuc66 added this to the 1.7.1 milestone May 1, 2020
@kostrse
Copy link
Author

kostrse commented May 2, 2020

Thanks!. The test project is an example of host application in this case which can perfectly reference a later version of Newtonsoft.Json package than JsonSubTypes does.

manuc66 added a commit that referenced this issue Jun 16, 2020
…onsoft.Json

#101 Lower Newtonsoft.Json dependency down to 10.0.1
@manuc66 manuc66 closed this as completed Sep 23, 2020
@manuc66
Copy link
Owner

manuc66 commented May 9, 2022

Published with version 1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants