Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonSubTypes does not have a strong name #75

Closed
lemoinem opened this issue Jun 6, 2019 · 0 comments
Closed

JsonSubTypes does not have a strong name #75

lemoinem opened this issue Jun 6, 2019 · 0 comments
Labels
feature-request
Milestone
1.6.0

Comments

@lemoinem
Copy link

lemoinem commented Jun 6, 2019

Expected behavior

It would be great if the NuGet package was strong named.
https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming#create-strong-named-net-libraries

Actual behavior

Importing the package from NuGet (v1.5.2.0), I'm getting the warning "Referenced assembly 'JsonSubTypes, Version=15.2.0, Culture=neutral, PublicKeyToken=null' does not have a strong name"

Steps to reproduce

Install JsonSubTypes via NuGet on any strongly named assembly.
manuc66 added a commit that referenced this issue Jun 10, 2019
@manuc66
add and use key for strong naming #75
0676265
@manuc66 manuc66 added this to the 1.6.0 milestone Jun 24, 2019
@manuc66 manuc66 closed this as completed Jun 24, 2019
manuc66 added a commit that referenced this issue Jun 24, 2019
@manuc66
Merge pull request #77 from manuc66/feature/strong-naming
bfb0cc0 
add and use key for strong naming #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@lemoinem @manuc66