Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for System.Text.Json #85

Open
brechtvhb opened this issue Sep 27, 2019 · 11 comments
Open

Support for System.Text.Json #85

brechtvhb opened this issue Sep 27, 2019 · 11 comments

Comments

@brechtvhb
Copy link

Could you update the application so it supports the default json formatter in .Net core 3?

@chinwobble
Copy link

+1 would be useful to support System.Text.Json. However I'm not sure if that library has the ability to do this yet.

@manuc66
Copy link
Owner

manuc66 commented Oct 11, 2019

First of all, Hi

Then yes it something that may comes some day, it needs some time to dig into the new api, I may look into into it in the future

@manuc66 manuc66 added this to the 2.0 milestone Oct 12, 2019
@siewers
Copy link

siewers commented Oct 24, 2019

Hi ;)
This would actually be quite useful since System.Text.Json doesn't support anything like that at the moment :)

@kimsey0
Copy link
Contributor

kimsey0 commented Oct 28, 2019

@brechtvhb: Could this issue be renamed to "Support System.Text.Json", since JsonSubTypes supports Json.NET just fine in .NET Core 3?

@brechtvhb brechtvhb changed the title .NET core 3 support Support for System.Text.Json in .net core 3 Oct 28, 2019
@manuc66 manuc66 changed the title Support for System.Text.Json in .net core 3 Support for System.Text.Json in .NET Core 3 Oct 29, 2019
manuc66 added a commit that referenced this issue Feb 23, 2020
manuc66 added a commit that referenced this issue Feb 23, 2020
Make most test run or failing
manuc66 added a commit that referenced this issue Feb 23, 2020
manuc66 added a commit that referenced this issue Feb 23, 2020
manuc66 added a commit that referenced this issue Feb 24, 2020
@voxon2
Copy link

voxon2 commented Jul 10, 2020

If your like me and just updated your project to .netcore 3.1 and now your types wont serialize correctly.

just install https://www.nuget.org/packages/Microsoft.AspNetCore.Mvc.NewtonsoftJson and you should be good to go.

@Luburic
Copy link

Luburic commented May 18, 2021

@manuc66 Just wanted to check what the current roadmap for this feature is and if it still planned?

.NET 5 has enhanced System.Text.Json and it seems to be sufficient for most cases, allowing projects to avoid adding another dependency through Newtonsoft.

@kimsey0
Copy link
Contributor

kimsey0 commented Oct 19, 2021

@manuc66: Do you have an overview of what's missing on https://github.com/manuc66/JsonSubTypes/compare/feature/Text.Json.NETCore3__%238? Perhaps we can contribute to it. :-)

@manuc66
Copy link
Owner

manuc66 commented Oct 22, 2021

@kimsey0 If you open the branch https://github.com/manuc66/JsonSubTypes/tree/feature/Text.Json.NETCore3__%238 I've began implementing a new converter agains System.Text.Json in project JsonSubTypes.Text.Json. I've kept 62 tests and there are currently 27 failing.

Using multiple time the deserializer in the same json path/hierachy does not work

@manuc66
Copy link
Owner

manuc66 commented Mar 31, 2022

@kimsey0 The issue with recursive polymorphic deserialization has been solved.

Other feature are still missing (see failing tests)

@manuc66 manuc66 removed this from the 2.0 milestone Sep 10, 2022
@manuc66
Copy link
Owner

manuc66 commented Sep 10, 2022

Please note that this kind of feature is coming in System.Text.Json dotnet/runtime#63747

@manuc66 manuc66 changed the title Support for System.Text.Json in .NET Core 3 Support for System.Text.Json Oct 18, 2022
@riezebosch
Copy link

Unaware of this package I implemented this: https://github.com/riezebosch/PolymorphicJsonTypeInfoResolver 🤘🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants