Throw when try to set the root object #24

IvanGoncharov · 2016-10-17T23:47:07Z

Before this changes:

var obj = {};
pointer.set(obj, '', 'bla');
console.log(JSON.stringify(obj)); //{"undefined": "bla"}

Before this changes: ```js var obj = {}; pointer.set(obj, '', 'bla'); console.log(JSON.stringify(obj)); //{"undefined": "bla"} ```

IvanGoncharov · 2016-10-19T15:35:34Z

@manuelstofer @epoberezkin Can you please review this PR?

epoberezkin · 2016-10-19T16:14:39Z

looks good

epoberezkin · 2016-10-19T16:25:41Z

@IvanGoncharov Actually some note in docs would be helpful here too... I don't mind adding it or you can, please let me know.

IvanGoncharov · 2016-10-20T13:44:15Z

@epoberezkin Thanks, it would be great if you add it 👍

Throw when try to set the root object

76ca03b

Before this changes: ```js var obj = {}; pointer.set(obj, '', 'bla'); console.log(JSON.stringify(obj)); //{"undefined": "bla"} ```

epoberezkin merged commit 322eb1e into manuelstofer:master Oct 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw when try to set the root object #24

Throw when try to set the root object #24

IvanGoncharov commented Oct 17, 2016

IvanGoncharov commented Oct 19, 2016

epoberezkin commented Oct 19, 2016

epoberezkin commented Oct 19, 2016

IvanGoncharov commented Oct 20, 2016

Throw when try to set the root object #24

Throw when try to set the root object #24

Conversation

IvanGoncharov commented Oct 17, 2016

IvanGoncharov commented Oct 19, 2016

epoberezkin commented Oct 19, 2016

epoberezkin commented Oct 19, 2016

IvanGoncharov commented Oct 20, 2016