Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STUDIO-2240 Add speaker, battery, charger icons #1037

Merged
merged 7 commits into from
May 15, 2024

Conversation

badiuoanaalexandra
Copy link
Contributor

@badiuoanaalexandra badiuoanaalexandra commented May 15, 2024

@badiuoanaalexandra badiuoanaalexandra changed the title Add speaker, battery, charger icons STUDIO-2240 Add speaker, battery, charger icons May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exported from the figma file? It is a bit strange that the icon is not in the middle of the canvas 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it is, what do you mean it is not in the middle?
image

Copy link
Contributor Author

@badiuoanaalexandra badiuoanaalexandra May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has viewBox="0 0 8 14" , and other ones have 18 18, but at least when showing the icon it looks like it is in the middle ? If I change that then it doesn't show in the middle anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should ask Stephen to export them with viewbox of 18 18?

Copy link
Contributor Author

@badiuoanaalexandra badiuoanaalexandra May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see that it is not in the middle? At least if I run the app it they all look correct?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I mean the left side looks having 2 pixel padding

Copy link
Contributor Author

@badiuoanaalexandra badiuoanaalexandra May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaah.. didn't even notice this.. I'll try to see if I can export it without that

Copy link
Contributor Author

@badiuoanaalexandra badiuoanaalexandra May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check again? I exported it with viewBox="0 0 16 16" (a bit above than before)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are charger.svg and speaker.svg are white by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just exported it like that, I removed the fill

@badiuoanaalexandra badiuoanaalexandra merged commit 5354b68 into publisher-staging May 15, 2024
4 checks passed
@tristen tristen deleted the add-icons branch May 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants