This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Small browersification prep #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 56d69ab68ab18cc920e8682a993b4e05c387dd06)
(cherry picked from commit d81b4b9d184601b55ce6e68a26d6035ca1e0077a)
|
The failing travis test is a timeout that happens on master too Appveyor fails to check out the PR, and this is happening with master too. |
|
What's the intent of this change? Browserify is a tool for avoiding globals and bundling dependencies via a standardized system. This change pushes CartoCSS toward globals and away from CommonJS. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #413
Changes from
CartoDB/carto@56d69ab
CartoDB/carto@d81b4b9