-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate storing vertex coords in Node for performance #31
Comments
@jfirebaugh pushed in # node-vertex
typical OSM building (15 vertices): x 736,335 ops/sec ±0.67% (100 runs sampled)
dude shape (94 vertices): x 35,703 ops/sec ±0.81% (97 runs sampled)
dude shape with holes (104 vertices): x 22,036 ops/sec ±0.63% (99 runs sampled)
complex OSM water (2523 vertices): x 546 ops/sec ±1.23% (95 runs sampled)
# master
typical OSM building (15 vertices): x 660,687 ops/sec ±0.54% (99 runs sampled)
dude shape (94 vertices): x 36,895 ops/sec ±0.41% (100 runs sampled)
dude shape with holes (104 vertices): x 28,153 ops/sec ±0.81% (98 runs sampled)
complex OSM water (2523 vertices): x 618 ops/sec ±0.51% (98 runs sampled) I have no idea why. Perhaps cache locality is better in master, because the vertex data is one array? |
Want to revisit this after #40, the perf results will probably be different. |
This looks much better after #40, just as I thought:
|
Ref: mapbox/earcut.hpp#10. We should try this and benchmark. cc @jfirebaugh
The text was updated successfully, but these errors were encountered: