Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when a hole is touching an outer ring #39

Closed
mourner opened this issue Oct 18, 2015 · 3 comments · Fixed by #40
Closed

Errors when a hole is touching an outer ring #39

mourner opened this issue Oct 18, 2015 · 3 comments · Fixed by #40
Labels

Comments

@mourner mourner added the bug label Oct 18, 2015
@mourner
Copy link
Member Author

mourner commented Oct 21, 2015

The root cause of the issue is that the polygons Earcut sometimes fails on polygons with different vertices touching each other, like here where a hole vertice touches an outer ring vertice:

image

I'm now looking into a good way to handle cases like this without degrading performance.

@mourner
Copy link
Member Author

mourner commented Oct 21, 2015

All failure samples are verified to be fixed by #40 \o/ cc @lbud @yhahn @springmeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant