-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature id support #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending fix of the Travis build.
include/mapbox/geojsonvt/tile.hpp
Outdated
}); | ||
} | ||
} | ||
|
||
template <class T> | ||
void addFeature(const T& multi, const property_map& props) { | ||
void addFeature(const T& multi, const property_map& props, const std::experimental::optional<identifier>& id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe alias std::experimental::optional<identifier>
to optional_identifier
, which is repeated a lot?
Build is failing due to linker errors that stem from this difference:
@springmeyer @kkaefer Do you know why |
@jfirebaugh yeah, I recently debugged exactly that: GLFW only uses higher-level NS* objects, which are part of the Cocoa framework, and does not use any lower-level CGL* symbols. The OpenGL Framework is misleadingly named in that it contains the CGL implementation. The actual GL implementation is in |
Ok, what does that mean for fixing the linker error? |
@springmeyer Could you look into why the clang-3.8 build is failing? |
Yes. @jfirebaugh latest mason only provides clang++ stable releases of 3.8.1 and 3.9.1 (https://github.com/mapbox/mason/blob/master/CHANGELOG.md#040). So, I'd recommend upgrading to 3.9. This is available in #61 |
Fixes #59
Ports mapbox/geojson-vt@9ec3ea8