This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
symbolZOrder example #245
Open
symbolZOrder example #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captainbarbosa ready for review, pending addition of new images (as discussed)! |
captainbarbosa
force-pushed
the
symbolzorder-example
branch
from
de7388f to
276798c
Compare
Fix product bundle identifier Fix SwiftLint line spacing warnings
captainbarbosa
force-pushed
the
symbolzorder-example
branch
from
276798c to
eff2d81
Compare
captainbarbosa
suggested changes
Nov 20, 2018
| // Add icons to the map's style. | ||
| [style setImage:([UIImage imageNamed:@"oval"]) forName:@"oval"]; | ||
| [style setImage:([UIImage imageNamed:@"squircle"]) forName:@"squircle"]; | ||
| [style setImage:([UIImage imageNamed:@"star"]) forName:@"star"]; |
There was a problem hiding this comment.
Just for clarity, I recommend making the string used for the image name something more unique so that it doesn't match, like this:
[style setImage:([UIImage imageNamed:@"oval-image"]) forName:@"oval"];That way once you set up your dictionary it would illustrate that each pair of the key/value strings are different values.
added 3 commits
November 26, 2018 15:15
…ples into symbolzorder-example
|
Thanks, @captainbarbosa. Code updated per your comments. Now just waiting for you to create new images (thank you!) and then figure out about this Podfile conflict and we should be good to go. |
|
Might have found a bug blocking this from working: mapbox/mapbox-gl-native#13490 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a first draft for now!