This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Handle deprecated locales #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2018 17:12
1ec5
reviewed
May 1, 2018
index.js
Outdated
| @@ -88,6 +90,14 @@ function parseLocaleIntoCodes (locale) { | |||
| }; | |||
| } | |||
|
|
|||
| function handleDeprecatedLocales(language) { | |||
There was a problem hiding this comment.
“Handle” isn’t a useful word to put in a function name. How about getStandardLanguage()?
lib/deprecated-locales.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| module.exports = [{ | |||
| previously: 'iw', | |||
| current: 'he' | |||
There was a problem hiding this comment.
This doesn’t need to be an array of objects. A simple object mapping deprecated codes to standard codes would do. If we need to attach more information to each entry in the future, we can use nested objects again. But for now it just makes getStandardLanguage() more complicated and less performant.
| @@ -22,6 +25,11 @@ tape('test bestMatchingLocale', function(t) { | |||
| t.equal(locale.bestMatchingLocale('es-mx', availableLocales), 'es'); | |||
| t.equal(locale.bestMatchingLocale('zh-Hans-region', availableLocales), 'zh-Hans'); | |||
| t.equal(locale.bestMatchingLocale('pt-BR', availableLocales), 'pt-PT'); | |||
|
|
|||
| t.equal(locale.bestMatchingLocale('iw', availableLocales), 'he', 'Test deprecated locale'); | |||
There was a problem hiding this comment.
Add a test case for a deprecated language plus a country code, such as iw-IL.
added 2 commits
April 30, 2018 17:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4
This handles older, deprecated locales by inspecting the language component of a locale and seeing if it is one of the deprecated locales. If it is, the current locale is returned instead.
/cc @danpaz @1ec5