Turf v2.0.0-alpha.2 #517
Merged
Turf v2.0.0-alpha.2 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Feb 9, 2021
There was a problem hiding this comment.
v2.0.0-alpha.2 has been tagged. We need to upgrade to that tag, which has the correct build flags. We should also update the Cartfile and podspecs for consistency across dependency managers, especially since v2.0.0-alpha.2 has some unrelated type changes that haven’t been released as part of v1.3.0 yet.
|
Linux builds are failing: Per mapbox/turf-swift#133 (comment), we’ll need to either exclude tvOS, watchOS, and Linux from this branch of MapboxDirections or conditionally have those platforms depend on a different tag of MapboxDirections. |
Sounds like a reasonable trade-off for the Public Preview, and one that we should reconsider before GA. |
MaximAlien
approved these changes
Feb 18, 2021
zugaldia
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires Turf
v2.0.0-alpha.1v2.0.0-alpha.2 as a stopgap to unblock mapbox/mapbox-navigation-ios#2629 and mapbox/mapbox-navigation-ios#2794. This PR will be merged to the release-v2.0 branch, which will not be merged into the main branch until we eliminate the need for a binary Turf distribution (mapbox/turf-swift#133) when using SPM./cc @mapbox/navigation-ios @macdrevx