Fix Turnstile Obfuscation #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 10, 2020 13:04
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
============================================
+ Coverage 68.35% 68.44% +0.09%
- Complexity 392 393 +1
============================================
Files 68 68
Lines 2152 2152
Branches 172 172
============================================
+ Hits 1471 1473 +2
+ Misses 582 581 -1
+ Partials 99 98 -1 |
harvsu
force-pushed
the
harvsu-proguard-rules
branch
from
ec924b7
to
80f4073
Compare
alfwatt
reviewed
Feb 25, 2020
Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet!
harvsu
force-pushed
the
harvsu-proguard-rules
branch
from
80f4073
to
44d0fbf
Compare
tobrun
reviewed
Feb 26, 2020
libtelemetry/src/main/java/com/mapbox/android/telemetry/AppUserTurnstile.java
Show resolved
Hide resolved
harvsu
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet! (cherry picked from commit 5f6d6ff)
harvsu
pushed a commit
that referenced
this pull request
Mar 16, 2020
harvsu
pushed a commit
that referenced
this pull request
Mar 16, 2020
Set version in gradle.properties . Replace master with long-term-support in config.yml .
harvsu
added a commit
that referenced
this pull request
Mar 17, 2020
harvsu
added a commit
that referenced
this pull request
Mar 17, 2020
* Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet!
harvsu
added a commit
that referenced
this pull request
Mar 17, 2020
* Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet!
harvsu
added a commit
that referenced
this pull request
Mar 18, 2020
* Update Changelog.md for release Core 1.4.0 / Telemetry 4.7.0(#440) * Update Gradle Versions: (#444) Gradle Version : 5.6.4 Android Gradle Plugin Version : 3.5.3 * Update Node version to >=10 in package.json (#445) Update version to 4.7.1 in package.json * Workaround for Strict mode socket issue: (#443) Add custom socket factory and set TrafficStats.setThreadStatsTag(1000) for configuration client(okhttpClient). * Fix Turnstile Obfuscation (#457) * Fix obfuscation: Prevent obfuscation of Event classes to keep properties in JSON schema unaltered. Throw Assertion Error in Test App in case of POST failure for an event. Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app. Add button on test app's main screen, which sends turnstile event on click. Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events. Fix Location Schema test to ignore the properties(speed, course, floor, speedAccuracy, courseAccuracy, and verticalAccuracy) that are added in the backend but not incorporated into the SDK yet! * Update Config.yml to indicate long-term-support as pseudo master branch. Append -lts to name of the binary while publishing the binary size. Update Version in gradle.properties and package.json.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the obfuscation/shrinking in Telemetry SDK that causes malformed Turnstile Events as mentioned in #456
Prevent obfuscation of Event classes to keep properties in JSON schema unaltered dfor serialization. Use @keep annotation(instead of adding in Proguard config as recommended in Replace Proguard rules with @Keep annotations mapbox-gl-native#8978) as a top level setting to keep Event class as is.
Throw Assertion Error in Test App in case of POST failure for an event.
Set minifyEnabled true in build.gradle for debug build to make the test app behave close to production app.
Add button on test app's main screen, which sends turnstile event on click.
Add @SerializedName annotation to Turnstile and Crash Event properties to keep them consistent with other events.
Fix Location Schema test to ignore the properties(speed, course, floor,
speedAccuracy, courseAccuracy, and verticalAccuracy) that are
added in the backend but not incorporated into the SDK yet!