Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving release process to Bintray #72

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith added the WIP label Jul 1, 2019
@langsmith
Copy link
Contributor Author

More weird Bintray 🐛 at the finish line of these Bintray prs. For this repo, it's a Invalid publication 'MapboxGesturesPublication': artifact file does not exist: '/Users/LangstonSmith/Mapbox/mapbox-gestures-android/library/build/libs/library-sources.jar.asc' message

On my local machine, make release works just fine for building the project. When I try to publish to Bintray via make publish-stable, I get the following 💥below:

Screen Shot 2019-07-01 at 10 18 27 AM

No worries if not @LukasPaczos , but any ideas about the missing .asc file?

@langsmith
Copy link
Contributor Author

Found gradle/gradle#3635 and tried some suggestions in that thread, but nothing worked.

@langsmith
Copy link
Contributor Author

langsmith commented Jul 1, 2019

Also related:

https://discuss.gradle.org/t/how-to-publish-artifacts-signatures-asc-files-using-maven-publish-plugin/7422/23

bintray/gradle-bintray-plugin#255 (comment) looks promising but that's with the assumption that the .asc file is even generated.

@LukasPaczos
Copy link
Member

any ideas about the missing .asc file

I believe that those are the signed artifacts. Are you sure that your mapboxGpgPassphrase was correctly set on your local machine when you tested?

@langsmith langsmith force-pushed the ls-moving-release-process-to-bintray branch from dbe100e to 35c87c7 Compare July 2, 2019 17:31
@langsmith
Copy link
Contributor Author

Figured out what the issue was. I hadn't deleted the mvn-push-android.gradle file and the reference to it at https://github.com/mapbox/mapbox-gestures-android/blob/master/build.gradle#L28 🤦‍♂🤦‍♂🤦‍♂🤦‍♂. It was interfering with my new Bintray setup .

When I deleted it, ran make release, and then ran make publish-stable, everything uploaded to Bintray just fine 🎊 https://bintray.com/mapbox/mapbox/mapbox-android-gestures

As a test and to get MavenCentral sync permission, I've published 0.5.0 on Bintray. We can delete later.

Screen Shot 2019-07-02 at 10 24 59 AM

Still getting that weird message when I request SNAPSHOT, but we can cross that bridge when we get to it. Things seemed to resolve themselves in mapbox/mapbox-java#1037
Screen Shot 2019-07-02 at 10 28 23 AM

Screen Shot 2019-07-02 at 10 28 55 AM

@langsmith langsmith marked this pull request as ready for review July 2, 2019 17:34
@langsmith langsmith self-assigned this Jul 2, 2019
@langsmith
Copy link
Contributor Author

Looks like we're good to go with SNAPSHOTs too

Screen Shot 2019-07-02 at 10 49 42 PM

Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release process is missing the step that changes the version name and removes the SNAPSHOT reference in order to support a full tag release. Check out this step.

Makefile Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
circle.yml Outdated Show resolved Hide resolved
gradle/javadoc.gradle Show resolved Hide resolved
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the readme should be updated with the new snapshot repository URL.

@langsmith
Copy link
Contributor Author

The release process is missing the step that changes the version name and removes the SNAPSHOT reference in order to support a full tag release. Check out this step.

Added to circle.yml.

Also, the readme should be updated with the new snapshot repository URL.

Updated.

@langsmith
Copy link
Contributor Author

Ok @LukasPaczos , just pushed a commit to address your latest review.

Makefile Outdated Show resolved Hide resolved
library/build.gradle Outdated Show resolved Hide resolved
library/build.gradle Outdated Show resolved Hide resolved
library/build.gradle Outdated Show resolved Hide resolved
library/build.gradle Outdated Show resolved Hide resolved
@langsmith langsmith force-pushed the ls-moving-release-process-to-bintray branch from b01b3e5 to 6a696db Compare July 4, 2019 08:00
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@langsmith langsmith merged commit 13212fd into master Jul 4, 2019
@langsmith langsmith deleted the ls-moving-release-process-to-bintray branch July 4, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the release process to be based on Bintray
2 participants