Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

support Polygons and LineStrings via their bbox #13

Merged
merged 3 commits into from
May 8, 2018

Conversation

andrewharvey
Copy link
Collaborator

No description provided.

@andrewharvey
Copy link
Collaborator Author

This doesn't merge features across tile boundaries, so you can end up with multiple accessible elements for each feature.

I considered using a feature id if exists to give strictly 1 accessible element per feature, but it might make sense to see if this get's addressed in GL JS mapbox/mapbox-gl-js#6019

@tristen
Copy link
Member

tristen commented May 8, 2018

Sweet!

Can the changes added to example.index.js be split into its own example instead? Demonstrating adding a custom source and applying accessibility to it.

@andrewharvey andrewharvey mentioned this pull request May 8, 2018
@andrewharvey
Copy link
Collaborator Author

Can the changes added to example.index.js be split into its own example instead? Demonstrating adding a custom source and applying accessibility to it.

Sure. I think at some point it makes sense to move the examples into mapbox-gl-js as it ensures they are more easily discoverable and we leverage all the existing infrastructure, re hosting, easy viewing online, auto access token.

@andrewharvey andrewharvey merged commit 4f199f4 into mapbox:mb-pages May 8, 2018
@andrewharvey andrewharvey deleted the bbox-geometries branch May 8, 2018 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants