don't add duplicate layers when custom styles are provided #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #167 |
|
Thanks for looking into this one Molly! Are these updates accessible on npm via v3.1.2 tag or should we be pulling from master? |
|
its not merged into master yet @bryantAXS – but once it gets approved and merged we'll try to get a new release out ASAP |
|
Any updates on this one being merged? Thanks! |
lbud
approved these changes
Mar 20, 2018
|
Thanks for fixing this! Any ETA on a new release? This issue is quite problematic for a shipped product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when custom styles are being used, this plugin was adding both the default and the custom layers to the map which was uncaught by mapbox-gl-js until mapbox/mapbox-gl-js#6147