Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mapboxgl peer dependency versions, update contributing.md #298

Merged
merged 1 commit into from
Feb 27, 2023
Merged

update mapboxgl peer dependency versions, update contributing.md #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Developing

yarn install & yarn start & open http://localhost:9966/example/
npm install & npm start & open http://localhost:9966/

You'll need a [Mapbox access token](https://www.mapbox.com/help/create-api-access-token/) stored in localstorage. Set it via

Expand All @@ -10,7 +10,7 @@ You'll need a [Mapbox access token](https://www.mapbox.com/help/create-api-acces

Tests require an MapboxAccessToken env variable to be set.

export MapboxAccessToken=<YOUR ACCESS TOKEN> && yarn test
export MapboxAccessToken=<YOUR ACCESS TOKEN> && npm test

### Release process

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var directions = new MapboxDirections({

var map = new mapboxgl.Map({
container: 'map',
style: 'mapbox://styles/mapbox/streets-v9'
style: 'mapbox://styles/mapbox/streets-v12'
});

map.addControl(directions, 'top-left');
Expand Down
2 changes: 1 addition & 1 deletion example/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ mapDiv.style = 'position:absolute;top:0;right:0;left:0;bottom:0;';
var map = window.map = new mapboxgl.Map({
hash: true,
container: mapDiv,
style: 'mapbox://styles/mapbox/streets-v9',
style: 'mapbox://styles/mapbox/streets-v12',
center: [-79.4512, 43.6568],
zoom: 13
});
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
]
},
"peerDependencies": {
"mapbox-gl": "^0.41.0 <2.0.0"
"mapbox-gl": "^1 || ^2"
},
"scripts": {
"prepublish": "npm run build",
Expand Down