Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLJS-647] Fixed displaying of waypoints on the route #310

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

underoot
Copy link
Member

@underoot underoot commented Jan 15, 2024

  • Added support of displaying route and instructions for all route lags, which means that missed waypoint functionality also was fixed.
  • Added relevant integration test.
  • Broken and noisy tests were updated to be clean and test more realistic scenario. For example check that instructions actually were rendered and it's not just error message.
  • Updated Mapbox GLJS to latest supported version
  • Switched from deprecated "deep-assign" to "lodash.merge" in setOptions action
  • Get rid off store and request singletons. Some assertions because of that had been launched couple of times
waypoints.mov

@underoot underoot changed the title Underoot gljs 647 Fixed displaying of waypoints on the route Jan 15, 2024
@underoot underoot requested a review from stepankuzmin January 15, 2024 14:58
@underoot underoot marked this pull request as ready for review January 15, 2024 14:58
@underoot underoot changed the title Fixed displaying of waypoints on the route [GLJS-647] Fixed displaying of waypoints on the route Jan 15, 2024
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants