Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLJS-647] Added configuration for waypoint instructions #313

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

underoot
Copy link
Member

  • Added options instructions.showWaypointInstructions, which controls displaying of instructions for waypoints
  • Added test for switching of this options
  • Updated documentation

Examples

var directions = new MapboxDirections({
  instructions: {
    showWaypointInstructions: false
  }
});
image
var directions = new MapboxDirections({
  instructions: {
    showWaypointInstructions: true
  }
});

// or
var directions = new MapboxDirections();
image

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need an option to turn off waypoint instructions, but anywise looks good to me 👍

@underoot
Copy link
Member Author

Not sure if we need an option to turn off waypoint instructions

It was a feature request

@underoot underoot merged commit 4214e45 into master Feb 22, 2024
8 checks passed
@underoot underoot deleted the underoot-GLJS-647-2 branch February 22, 2024 13:20
@underoot underoot mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants