Trigger featureChanged on feature props change #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
approved these changes
Aug 22, 2023
Merged
petermoz
pushed a commit
to petermoz/mapbox-gl-draw
that referenced
this pull request
Oct 4, 2023
mapbox#1196 intended to add a call to `featureChanged` any time a feature was `add()`ed with modified properties, however it has a bug in that the check came after assignment. A simpler fix would be to move the assignment inside the `if()` body, but that could break other code that depended on referential equality after calling `add()`.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
This reverts commit 357ede0.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1122