calculate matrices after constraining (#3518)

Fixes #3474.
mapbox · Nov 2, 2016 · f829bd0 · f829bd0
1 parent dce1abb
commit f829bd0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/js/geo/transform.js b/js/geo/transform.js
@@ -112,17 +112,17 @@ class Transform {
         this.scale = this.zoomScale(z);
         this.tileZoom = Math.floor(z);
         this.zoomFraction = z - this.tileZoom;
-        this._calcMatrices();
         this._constrain();
+        this._calcMatrices();
     }
 
     get center() { return this._center; }
     set center(center) {
         if (center.lat === this._center.lat && center.lng === this._center.lng) return;
         this._unmodified = false;
         this._center = center;
-        this._calcMatrices();
         this._constrain();
+        this._calcMatrices();
     }
 
     /**
@@ -177,8 +177,8 @@ class Transform {
         this.height = height;
 
         this.pixelsToGLUnits = [2 / width, -2 / height];
-        this._calcMatrices();
         this._constrain();
+        this._calcMatrices();
     }
 
     get unmodified() { return this._unmodified; }

diff --git a/test/js/geo/transform.test.js b/test/js/geo/transform.test.js
@@ -45,6 +45,13 @@ test('transform', (t) => {
         t.end();
     });
 
+    t.test('does not throw on bad center', (t) => {
+        const transform = new Transform();
+        transform.resize(500, 500);
+        transform.center = {lng: 50, lat: -90};
+        t.end();
+    });
+
     t.test('panBy', (t) => {
         const transform = new Transform();
         transform.resize(500, 500);