-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of the mapboxgl.Control class #2118
Labels
Comments
Would we deprecate/remove existing methods like cc @mourner |
We could deprecate the class and alias
|
2 tasks
For the short term gl-draw has copied the Control class into its code base and removed the direct dependency. |
lucaswoj
added
breaking change ⚠️
Requires a backwards-incompatible change to the API
medium priority
and removed
medium priority
v1
labels
Aug 25, 2016
Done in #3497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We shouldn't require 3rd party plugins to
require('mapbox-gl').Control
in their module. All the code in this class could be easily moved elsewhere (i.e.map#addControl
andmap#removeControl
methods).ref mapbox/mapbox-gl-draw#235
The text was updated successfully, but these errors were encountered: