Moving to a mock for tests #244
Conversation
mcwhittemore
force-pushed
the
make-tests-work
branch
4 times, most recently
from
9c0ee9d to
6ed5b5c
Compare
mcwhittemore
force-pushed
the
make-tests-work
branch
from
6ed5b5c to
87ac146
Compare
mcwhittemore
changed the title
|
Can someone take a look at this and make sure all is well? |
| @@ -12,8 +12,7 @@ | |||
| ] | |||
| }, | |||
| "scripts": { | |||
| "test": "npm run lint && npm run prepublish", | |||
| "test-unit": "browserify test/*.test.js | tap-closer | smokestack | tap-status", | |||
| "test": "tape -r ./test/mock-browser.js -r babel-register test/*.test.js", | |||
There was a problem hiding this comment.
Is the removal of linting here intentional?
There was a problem hiding this comment.
Yes. test-unit was the real tests but they couldn't run in circle so for circle we tested if we could build. I don't think we need to test this anymore, but if you have concerns about not testing the build in circle (its implicitly tested by publishing) I'm all ears.
There was a problem hiding this comment.
It's nice for making sure that PRs don't introduce linting problems to fail the tests on this
There was a problem hiding this comment.
+1 on including npm run lint
|
@mcwhittemore LGTM other than the things noted. Should probably try to add back in the skipped tests at some point but not necessary for this PR |
mcwhittemore
force-pushed
the
make-tests-work
branch
from
87ac146 to
77bd3bc
Compare
Moving to a mock for tests
Closes #235
Closes #200
Closes #197
This also makes it so
permanentfeatures aren't selectable withDraw.select().