Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Evented" write to the console when an error event is fired but no listeners are bound #2135

Closed
lucaswoj opened this issue Feb 17, 2016 · 1 comment

Comments

@lucaswoj
Copy link
Contributor

        if (!this.listens(type)) {
            if (util.endsWith(type, 'error')) {
                console.error(data && data.error && data.error.message);
            }
            return this;
        }

Not having this can cause errors to be silently ignored and unit tests to silently hang

@jfirebaugh
Copy link
Contributor

#2447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants