Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Evented print a warning message if an "error" event is lost #2447

Closed
lucaswoj opened this issue Apr 14, 2016 · 0 comments · Fixed by #2852
Closed

Make Evented print a warning message if an "error" event is lost #2447

lucaswoj opened this issue Apr 14, 2016 · 0 comments · Fixed by #2852
Assignees
@lucaswoj
Labels
feature 🍏

Comments

@lucaswoj
Copy link
Contributor

If an error event is fired but doesn't trigger any listeners, we should print a warning and the error message. This would

  • display errors when a development mistake causes errors to not propogate to Map
  • display errors fired while running unit tests
  • eliminate the need for Map#onError

ref #2446
@lucaswoj lucaswoj mentioned this issue Apr 14, 2016
Closed
@lucaswoj lucaswoj self-assigned this Apr 14, 2016
@jfirebaugh jfirebaugh mentioned this issue Jul 7, 2016
Closed
lucaswoj pushed a commit that referenced this issue Jul 11, 2016
Don't silently drop error events
628f932 
fixes #2447
@lucaswoj lucaswoj mentioned this issue Jul 11, 2016
Merged
lucaswoj pushed a commit that referenced this issue Jul 14, 2016
Don't silently drop error events
b300b49 
fixes #2447
lucaswoj pushed a commit that referenced this issue Jul 20, 2016
Don't silently drop error events
9b8d376 
fixes #2447
lucaswoj added a commit that referenced this issue Jul 20, 2016
@lucaswoj
Don't silently drop error events (#2852)
86349ac 
* Don't silently drop error events

fixes #2447

* Remove console.trace call

* Remove onError method in favor of Evented error fallback

* Restore "logs errors that happen during render" test

* Add error event docs

* Prevent test suite crashes on error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaswoj lucaswoj

Labels
feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't silently drop error events mapbox/mapbox-gl-js
2 participants
@mourner @lucaswoj