Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't redo style validation in workers #3149

Closed
jfirebaugh opened this issue Sep 6, 2016 · 0 comments · Fixed by #3224
Closed

Don't redo style validation in workers #3149

jfirebaugh opened this issue Sep 6, 2016 · 0 comments · Fixed by #3224
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@jfirebaugh
Copy link
Contributor

In looking into #2991, I noticed that the workers are spending non-negligible amount of time during startup running style validation. Specifically, via 'set layers' ⇢ StyleLayer.create ⇢ StyleLayer#setPaintProperty / StyleLayer#setLayoutProperty.

This is unnecessary work: these layers have already been validated by the main thread. We should bypass validation in the worker.
@jfirebaugh jfirebaugh added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Sep 6, 2016
This was referenced Sep 6, 2016
Closed
Closed
@jfirebaugh jfirebaugh mentioned this issue Sep 19, 2016
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid unnecessary style validation mapbox/mapbox-gl-js
1 participant
@jfirebaugh