-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip style validation when loading a style from mapbox.com #3152
Comments
Could this be implemented as a setting (rather than caring about tile domain)? Add something like |
Perhaps we could sniff for a value like |
I like @lucaswoj's proposal. That way an application (such as my own) that switches client side styles frequently can skip style validation as well. Perhaps it even would be possible to have the style validation process cache its own outcome via a property on the style in the line of |
I realised my own proposal wouldn't work for any mutations you would carry out on the style object directly, but I still like the idea that clients can skip validations at their own will. |
How about making it an API option, rather than a metadata option? |
@jfirebaugh That would work, but as I understood your initial proposal you would like to have official Mapbox styles skip validation automatically, which perhaps is trickier if not part of the style definition but part of the API. |
Another approach would be to have "development mode" (validate everything) and "production mode" (skip all validations) settings at the global level. |
I think we want a granular option like
|
The other way around I assume? ;) Set to false if the user is uncertain... |
In looking into #2991, I noticed that overall, style validation consumes a non-neglible amount of resources at startup. In addition to #3149 and #3151, for styles loaded via mapbox.com APIs, we should skip validation entirely, because the APIs themselves enforce validity.
The text was updated successfully, but these errors were encountered: