Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups #325

Closed
3 tasks done
mourner opened this issue Mar 14, 2014 · 5 comments
Closed
3 tasks done

Popups #325

mourner opened this issue Mar 14, 2014 · 5 comments
Assignees

Comments

@mourner
Copy link
Member

mourner commented Mar 14, 2014

  • Implementation
  • Documentation
  • Example

We need an easy way to display some HTML info in a particular place, much like Leaflet does with the Popup class and methods.

@mourner mourner added this to the future milestone Jun 24, 2014
@jfirebaugh jfirebaugh self-assigned this Feb 17, 2015
jfirebaugh added a commit that referenced this issue Feb 17, 2015
jfirebaugh added a commit that referenced this issue Feb 17, 2015
@jfirebaugh
Copy link
Contributor

Basic implementation is there. There are some features of L.Popup that I'm comfortable not supporting for now (or ever):

  • minWidth/maxWidth/maxHeight options -- should be done with CSS if desired
  • opacity transition -- should be done with CSS if desired
  • having an open/close state that is separate from "on the map"/"removed from the map"
  • map.openPopup()/map.closePopup()

Features we might want to add:

  • offset option
  • autoPan and keepInView options -- but I'd rather support auto-anchoring the popup at the left, top, or right sides depending its position relative to the viewport. In general I think that's a better feature to have from a UX perspective. Having the map pan when a popup opens is often an annoyance.
  • specify content as DOM node
  • open/close events (except rename them add/remove)

@mourner
Copy link
Member Author

mourner commented Feb 18, 2015

Yeah, sounds good. I'm up for auto-anchoring, although autoPan would still be useful, it would just not pan as much with auto-anchoring — just a little in some cases like popup in a corner.

@mourner
Copy link
Member Author

mourner commented Feb 18, 2015

Or we could do something like http://erictheise.github.io/rrose/ — anchoring to 6 sides.

@jfirebaugh
Copy link
Contributor

Yeah, the rrose behavior is what I had in mind. I wonder if there's any way to do it with pure CSS.

@jd327
Copy link

jd327 commented Oct 5, 2016

@jfirebaugh @mourner any plans to get autoPan implemented? Couldn't find any open issues for it.

bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
clean up theme: better layer order, naming convention, styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants