Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document "icon-offset" units #4661

Closed
gmaclennan opened this issue Apr 29, 2017 · 0 comments
Closed

Document "icon-offset" units #4661

gmaclennan opened this issue Apr 29, 2017 · 0 comments
Labels
docs 📜

Comments

@gmaclennan
Copy link
Contributor

icon-offset units are strange #4078 - they are px * icon-size. This is not documented, and could potentially lead to somebody (me) spending lots of time figuring out what is going wrong.

Until #4078 is done, it would be good to document current behaviour.
ansis added a commit that referenced this issue May 8, 2017
@ansis
clarify icon-size units, fix #4661
e784f31
@ansis ansis mentioned this issue May 8, 2017
Merged
2 tasks
ansis added a commit that referenced this issue May 8, 2017
@ansis
clarify icon-size units, fix #4661
efc6feb
1ec5 pushed a commit that referenced this issue May 8, 2017
@ansis @1ec5
clarify icon-size units, fix #4661
990cd15
lbud pushed a commit that referenced this issue Jun 9, 2017
@ansis
clarify icon-size units, fix #4661
5465abc
@jfirebaugh jfirebaugh mentioned this issue Sep 12, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs 📜
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfirebaugh @gmaclennan @mollymerp