Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrossTileSymbolIndex leaks removed layers #5995

Closed
ChrisLoer opened this issue Jan 12, 2018 · 1 comment
Closed

CrossTileSymbolIndex leaks removed layers #5995

ChrisLoer opened this issue Jan 12, 2018 · 1 comment
Assignees
@ChrisLoer

Comments

@ChrisLoer
Copy link
Contributor

When you add a layer, CrossTileSymbolIndex creates a new CrossTileSymbolLayerIndex, but there's no corresponding removal operation. If you re-add a layer with the same ID, the original layer index will be re-used, but if you keep creating layers with new IDs you could keep leaking layer indices.

/cc @ansis
@ChrisLoer ChrisLoer mentioned this issue Jan 17, 2018
Closed
@ChrisLoer ChrisLoer self-assigned this Jan 17, 2018
ChrisLoer added a commit that referenced this issue Jan 18, 2018
@ChrisLoer
Prune unused layers from the CrossTileSymbolIndex.
3688d83 
Fixes issue #5995 (index leaked removed layers)
@ChrisLoer ChrisLoer mentioned this issue Jan 18, 2018
Merged
ChrisLoer added a commit that referenced this issue Jan 22, 2018
@ChrisLoer
Prune unused layers from the CrossTileSymbolIndex.
decea3f 
Fixes issue #5995 (index leaked removed layers)
@ChrisLoer
Copy link
Contributor Author

Fixed via #6016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisLoer ChrisLoer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer