Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setData causes some labels to fade out and fade in #6002

Closed
ttsirkia opened this issue Jan 16, 2018 · 3 comments
Closed

setData causes some labels to fade out and fade in #6002

ttsirkia opened this issue Jan 16, 2018 · 3 comments
Labels
release blocker ⛔
Milestone
0.44.0

Comments

@ttsirkia
Copy link

mapbox-gl-js version: f232d74

Steps to Trigger Behavior

  1. Update data by calling setData

Expected Behavior

Labels stay where they are or move to a new position

Actual Behavior

Labels fade out and immediatelly back in.

f232d74 is the first version having this problem.
@ttsirkia
Copy link
Author

ttsirkia commented Jan 16, 2018 •
edited
Loading

https://jsfiddle.net/c0tg4h5o/2/

@ChrisLoer ChrisLoer mentioned this issue Jan 16, 2018
Merged
@ChrisLoer
Copy link
Contributor

Wow, who needs CI when we've got people like you testing our commits so quickly! 😉

I see the problem in the JSFiddle, investigating now.

@ChrisLoer ChrisLoer added this to the 0.44.0 milestone Jan 16, 2018
ChrisLoer added a commit that referenced this issue Jan 16, 2018
@ChrisLoer
Don't regenerate crossTileIDs when a bucket is updated.
b11ddc9 
Fixes issue #6002, which caused symbols to fade in and out during setData animations.
@ChrisLoer ChrisLoer mentioned this issue Jan 16, 2018
Merged
ChrisLoer added a commit that referenced this issue Jan 16, 2018
@ChrisLoer
Don't regenerate crossTileIDs when a bucket is updated.
ea28e71 
Fixes issue #6002, which caused symbols to fade in and out during setData animations.
@ChrisLoer
Copy link
Contributor

Fixed with #6003, thanks again @ttsirkia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release blocker ⛔
Projects
None yet
Milestone
0.44.0
Development

No branches or pull requests
2 participants
@ChrisLoer @ttsirkia