Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simultaneous map zoom and drag throws TypeError #6106

Closed
dm261395 opened this issue Feb 7, 2018 · 1 comment
Closed

Simultaneous map zoom and drag throws TypeError #6106

dm261395 opened this issue Feb 7, 2018 · 1 comment
Labels
bug 🐞 release blocker ⛔
Milestone
0.44.1

Comments

@dm261395
Copy link

dm261395 commented Feb 7, 2018

mapbox-gl-js version:
v0.44.0

Steps to Trigger Behavior

  1. On the Mapbox GL JS simple map example at https://www.mapbox.com/mapbox-gl-js/example/simple-map/, start zooming in or out on the map via the mouse wheel scroll.
  2. Before finishing zooming, click and drag the map in some direction.
  3. Type error is thrown (Chrome console output):

Uncaught TypeError: Cannot read property 'x' of undefined

GIF demonstration:
bug

I am on macOS High Sierra Version 10.13.3. I have encountered this error on Chrome Version 64.0.3282.140, Firefox Quantum v58.0 and Safari Version 11.0.3 since the mapbox-gl upgrade v0.44.0.
@anandthakker anandthakker added this to the 0.44.1 milestone Feb 7, 2018
anandthakker pushed a commit that referenced this issue Feb 8, 2018
Fix drag handlers to gracefully handle interruptions
95aedfa 
Closes #6106
@anandthakker anandthakker mentioned this issue Feb 8, 2018
Merged
anandthakker pushed a commit that referenced this issue Feb 9, 2018
Fix drag handlers to gracefully handle interruptions
f3904b2 
Closes #6106
anandthakker added a commit that referenced this issue Feb 9, 2018
@anandthakker
Fix drag handlers to gracefully handle interruptions (#6113)
c1e0b10 
Closes #6106
@mourner
Copy link
Member

mourner commented Feb 9, 2018

Fixed in #6113

@mourner mourner closed this as completed Feb 9, 2018
anandthakker pushed a commit that referenced this issue Feb 9, 2018
Fix drag handlers to gracefully handle interruptions
c699e56 
Closes #6106
anandthakker added a commit that referenced this issue Feb 9, 2018
@anandthakker
Fix drag handlers to gracefully handle interruptions (#6125)
adfc154 
Cherry picking #6113 into master 
Closes #6106
pathmapper pushed a commit to pathmapper/mapbox-gl-js that referenced this issue Feb 13, 2018
@anandthakker
Fix drag handlers to gracefully handle interruptions (mapbox#6125)
0152b33 
Cherry picking mapbox#6113 into master 
Closes mapbox#6106
pathmapper pushed a commit to pathmapper/mapbox-gl-js that referenced this issue Feb 13, 2018
@anandthakker
Fix drag handlers to gracefully handle interruptions (mapbox#6125)
9d8565f 
Cherry picking mapbox#6113 into master 
Closes mapbox#6106
@jfirebaugh jfirebaugh mentioned this issue Feb 15, 2018
Merged
@jfirebaugh jfirebaugh mentioned this issue Mar 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 release blocker ⛔
Projects
None yet
Milestone
0.44.1
Development

No branches or pull requests
3 participants
@mourner @anandthakker @dm261395