-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom layer immediate and draped rendering on globe and terrain #12182
Merged
Commits on Jan 24, 2023
-
WIP: Custom layer draping support
CustomStyleLayer API extended to support draping with new methods: export type CustomLayerInterface = { ... // misusing MercatorCoordiate's xyz for tile id (x, y, z) where wrap is baked into x. renderToTile: ?(gl: WebGLRenderingContext, tileId: MercatorCoordinate) => void, // return true only for frame when content has changed - otherwise, all the terrain // render cache would be invalidated and redrawn causing huge drop in performance. shouldRerenderTiles: ?() => boolean, } Using WebGL Wind demo code, for simplicity of use, instead of adding submodule, copied dist code. Full code is available at https://github.com/mapbox/webgl-wind/tree/astojilj-draping-support
Configuration menu - View commit details
-
Copy full SHA for 8b9071f - Browse repository at this point
Copy the full SHA 8b9071fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f06ee7 - Browse repository at this point
Copy the full SHA 9f06ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a604c2 - Browse repository at this point
Copy the full SHA 8a604c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2ed1b6 - Browse repository at this point
Copy the full SHA c2ed1b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2368a - Browse repository at this point
Copy the full SHA 1c2368aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb9cbe0 - Browse repository at this point
Copy the full SHA bb9cbe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17bba08 - Browse repository at this point
Copy the full SHA 17bba08View commit details -
Configuration menu - View commit details
-
Copy full SHA for bef8bc2 - Browse repository at this point
Copy the full SHA bef8bc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bda3020 - Browse repository at this point
Copy the full SHA bda3020View commit details -
Configuration menu - View commit details
-
Copy full SHA for d523d98 - Browse repository at this point
Copy the full SHA d523d98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4833451 - Browse repository at this point
Copy the full SHA 4833451View commit details -
Configuration menu - View commit details
-
Copy full SHA for 589b19d - Browse repository at this point
Copy the full SHA 589b19dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ace46 - Browse repository at this point
Copy the full SHA 65ace46View commit details -
Configuration menu - View commit details
-
Copy full SHA for cec55a8 - Browse repository at this point
Copy the full SHA cec55a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd26f28 - Browse repository at this point
Copy the full SHA fd26f28View commit details -
Configuration menu - View commit details
-
Copy full SHA for c490786 - Browse repository at this point
Copy the full SHA c490786View commit details -
Configuration menu - View commit details
-
Copy full SHA for a17bc70 - Browse repository at this point
Copy the full SHA a17bc70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32af347 - Browse repository at this point
Copy the full SHA 32af347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70a557d - Browse repository at this point
Copy the full SHA 70a557dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e00366 - Browse repository at this point
Copy the full SHA 1e00366View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf9173 - Browse repository at this point
Copy the full SHA dbf9173View commit details -
Configuration menu - View commit details
-
Copy full SHA for 835ea69 - Browse repository at this point
Copy the full SHA 835ea69View commit details -
Pass projection and resolve mercatorMatrix during transition
In globe projection, mercator matrix z scale was incorrect, disabling possibility for transition. Transform.mercatorMatrix changed in order to produce the expected mercator matrix, even in globe (zoom 5->6) transition, and then the same compensated in globe to mercator matrix. updated satellites_custom_layer.js to show transition and satellites in mercator projection.
Configuration menu - View commit details
-
Copy full SHA for edce689 - Browse repository at this point
Copy the full SHA edce689View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff45cae - Browse repository at this point
Copy the full SHA ff45caeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0979259 - Browse repository at this point
Copy the full SHA 0979259View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.