Update description for top slot
#12937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcritchley
reviewed
Oct 18, 2023
There was a problem hiding this comment.
@tayalav thanks for doing this! I had one suggestion for wording and looks like you might need to also update the changelog?
MIGRATION_GUIDE_v3.md
Outdated
|
|
||
| Set the preferred `slot` on the `Layer` object before adding it to your map and your layer will be appropriately placed in the Standard style's layer stack. | ||
| If no slot is specified for a custom layer then layers are still placed at the very top of the layer list, providing a location that has highest collision priority compared to all other layers. |
There was a problem hiding this comment.
@tayalav we could maybe shorten this sentence?
If no slot is specified for a custom layer they are placed at the very top of the layer list, providing a location that has highest collision priority compared to all other layers.
There was a problem hiding this comment.
@jcritchley sure, thanks for the suggestion!
stepankuzmin
added a commit
that referenced
this pull request
Oct 24, 2023
stepankuzmin
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Updated description for the "top" slot based on recent changes