Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support padding positions in fitBounds #1682

Closed
wants to merge 1 commit into from

Conversation

tristen
Copy link
Member

@tristen tristen commented Nov 9, 2015

@jfirebaugh
Copy link
Contributor

For the tests, try to find some bounds and padding values that make an appreciable difference in the result, and then assert equality using fixedLngLat (see other tests in the file for example). You could use fixedLngLat with the current values, and your tests would probably pass, but they wouldn't really be testing the different between not passing bounds, passing a single number, and passing an array, because the resulting difference is so small (< 0.0000000000001 degree of latitude / longitude).

@lucaswoj
Copy link
Contributor

@tristen Do we still want to add this functionality? Is there anything I can do to help you 🚢 this?

@tristen
Copy link
Member Author

tristen commented Feb 10, 2016

@lucaswoj this functionality would be amazing and I'd love help with it by basically making this commit legit - my change above isn't robust enough to flexibly adjust padding on all four sides.

@lucaswoj
Copy link
Contributor

Ok. In an effort to clean out stale PRs, lets close this for now, re-open #1339, and resume work when this feature becomes top-of-mind.

@lucaswoj lucaswoj closed this Feb 11, 2016
@jfirebaugh jfirebaugh deleted the fitbounds-padding-as-array branch February 3, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants