Refactor to inline StyleDeclarationSet into StyleLayer #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... why stop there. Ripped out the This is ready for 👀 |
lucaswoj
force-pushed
the
layer-2-1957
branch
from
2b697fc to
dc3b51f
Compare
| return util.extend({}, input, { | ||
| stops: input.stops.map(function(step) { | ||
| return [step[0], parseColor(step[1])]; | ||
| }) |
There was a problem hiding this comment.
This doesn't have to be a closure (created on every color) — function can be moved to top-level.
lucaswoj
force-pushed
the
layer-2-1957
branch
from
7fac858 to
ec62ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1963
We still use
StyleDeclarationSetinBucketfor now, but that'll go away with #1957.cc @ansis @mourner @jfirebaugh