-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cheapo WMS, Part II #2612
Cheapo WMS, Part II #2612
Conversation
The CI failure should be fixed by #2610. Can you rebase and re-push? Thanks! |
I'm 👍 on merging this pending:
|
What do you think about namespacing the bbox token behind a |
I thought about that, but worried that's misleading because we are only supporting a very specific subset of wms servers. We'd likely see people opening issues because they try to add |
My understanding is that Putting the wms-specific tokens to a wms namespace will increase the self-documenting-ness of the feature and give us maneuvering room to improve wms support in the future. Our likelihood of getting weird wms support requests is unrelated to the existence of a wms scheme. |
cc @yhahn @tmcw @jfirebaugh: As the lead TileJSON contributors, what's your feeling on this? |
I love this PR!
I see why we might want to scope this bigger, but don't feel like we need to or should. I think what we have here is pretty great. |
Ok! Let's 🚢! |
... as soon as I finish the hotfix release for #2657 |
Just pushed a few commits to bump to the v2 classless library, and added a test. We should think about how we want to communicate this feature. Should I document it in style-spec? |
This is being ported to the native libraries in mapbox/mapbox-gl-native#5628. |
Like #2409 but uses whoots-js library to calculate the bounding box with more correct math.
Also added a
wms.html
debug page.cc @tmcw @lucaswoj @mourner