Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a minimal global worker pool #2952

Merged
merged 18 commits into from
Aug 23, 2016
Merged

Add a minimal global worker pool #2952

merged 18 commits into from
Aug 23, 2016

Commits on Aug 23, 2016

  1. Enable Worker to do work for multiple map instances

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    ffaf8e8 View commit details
    Browse the repository at this point in the history

  2. Add minimal worker pool

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    9b887bf View commit details
    Browse the repository at this point in the history

  3. Include mapId in Actors' callback tracking

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    a7d50e8 View commit details
    Browse the repository at this point in the history

  4. Unit test Dispatcher's use of WorkerPool

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    71c9f6d View commit details
    Browse the repository at this point in the history

  5. Fix benchmark

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    63089fe View commit details
    Browse the repository at this point in the history

  6. Add WorkerPool unit tests

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    20bf840 View commit details
    Browse the repository at this point in the history

  7. Add a unit test for 2 Actors using the same Worker

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    93ba7fd View commit details
    Browse the repository at this point in the history

  8. Fix parameter in Worker 'redo placement' test

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    1747dc6 View commit details
    Browse the repository at this point in the history

  9. Add map load benchmark

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    78540cf View commit details
    Browse the repository at this point in the history

  10. Move the static worker pool instance to style.js 

    This is still not great, but it's better than having it in Dispatcher.
Ultimately the right place to put it is at the root level, i.e.
mapbox-gl.js, and then pass it through, but that will be a noisy change
due the number of 'new Map()' and 'new Style()' in the unit tests
    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    2e65562 View commit details
    Browse the repository at this point in the history

  11. Use a fixed worker pool size

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    ba02e2a View commit details
    Browse the repository at this point in the history

  12. Use empty style in load-multiple-maps benchmark

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    7210aaf View commit details
    Browse the repository at this point in the history

  13. Drop shared_workers debug in favor of multiple.html

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    6ac077d View commit details
    Browse the repository at this point in the history

  14. WorkerPool.WORKER_COUNT => mapboxgl.workerCount

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    0c687bb View commit details
    Browse the repository at this point in the history

  15. Fix webpack build test 

    The previous commit (2f00368) broke the
webpack test due to webpack/webpack#300. This
changes the webpack config so that mapbox-gl itself is not the
entrypoint.
    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    ff7c9e2 View commit details
    Browse the repository at this point in the history

  16. Use more descriptive parameter name, mapId

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    13b53ed View commit details
    Browse the repository at this point in the history

  17. Rename layers => layerDefinitions, styleLayers => layers

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    1efb12f View commit details
    Browse the repository at this point in the history

  18. Remove mapboxgl.WorkerPool

    Anand Thakker committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    ea12906 View commit details
    Browse the repository at this point in the history