Share a single blob URL between all workers #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
share-blob
branch
from
9a7af59
to
f693ec1
Compare
jfirebaugh
force-pushed
the
share-blob
branch
from
f693ec1
to
48138c0
Compare
mourner
approved these changes
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share a single blob URL between all workers (refs #3153). Turns out this is easy to do, so we might as well, even if the performance benefit is not significant.
Launch Checklist
Benchmarks
map-load
master 56e9761: 212 ms
share-blob 9a7af59: 71 ms
style-load
master 56e9761: 102 ms
share-blob 9a7af59: 112 ms
buffer
master 56e9761: 995 ms
share-blob 9a7af59: 991 ms
fps
master 56e9761: 60 fps
share-blob 9a7af59: 60 fps
frame-duration
master 56e9761: 7.3 ms, 0% > 16ms
share-blob 9a7af59: 7.4 ms, 0% > 16ms
query-point
master 56e9761: 0.98 ms
share-blob 9a7af59: 1.12 ms
query-box
master 56e9761: 70.14 ms
share-blob 9a7af59: 86.60 ms
geojson-setdata-small
master 56e9761: 14 ms
share-blob 9a7af59: 14 ms
geojson-setdata-large
master 56e9761: 121 ms
share-blob 9a7af59: 119 ms