DRY up VideoSource code #3353
Merged
DRY up VideoSource code #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention that this PR also fixes |
lucaswoj
reviewed
Oct 12, 2016
| @@ -107,92 +97,18 @@ VideoSource.prototype = util.inherit(Evented, /** @lends VideoSource.prototype * | |||
| /** | |||
| * Sets the video's coordinates and re-renders the map. | |||
| * | |||
| * @method setCoordinates | |||
| * @param {Array<Array<number>>} coordinates Four geographical coordinates, | |||
| * represented as arrays of longitude and latitude numbers, which define the corners of the video. | |||
| * The coordinates start at the top left corner of the video and proceed in clockwise order. | |||
| * They do not have to represent a rectangle. | |||
| * @returns {VideoSource} this | |||
| */ | |||
There was a problem hiding this comment.
Could we eliminate the need for this inherited comment by rewording it? s/video/source or s/video/data or s/video/layer?
There was a problem hiding this comment.
Maybe, but what to do with @returns {VideoSource}? cc @jfirebaugh
lucaswoj
approved these changes
Oct 12, 2016
lucaswoj
pushed a commit
that referenced
this pull request
Oct 12, 2016
This was referenced Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #3350, I noticed that most of the
VideoSourcecode is a copy-paste fromImageSource. This PR removes a lot of duplication by makingVideoSourceinherit fromImageSource.We might later consider some kind of composition instead of inheritance, or inheriting both from a shared base class (e.g.
GeoreferencedSource), but I'd leave that for later when we address #3186.👀 @lucaswoj @ansis