(not ready) Update examples for inline sources #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 5, 2017 15:06
jfirebaugh
suggested changes
Jan 6, 2017
| @@ -21,15 +21,15 @@ | |||
|
|
|||
| // Add a new source from our GeoJSON data and set the | |||
| // 'cluster' option to true. | |||
| map.addSource("earthquakes", { | |||
| var earthquakes = { | |||
There was a problem hiding this comment.
I don't think we should change examples such as this, where multiple layers use a single source.
| // Add a GeoJSON source containing place coordinates and information. | ||
| map.addSource("places", { | ||
| // Declare a GeoJSON source containing place coordinates and information. | ||
| var places = { |
There was a problem hiding this comment.
Let's inline the data rather than use a variable.
| // Add a GeoJSON source containing place coordinates and information. | ||
| map.addSource("places", { | ||
| // Declare a GeoJSON source containing place coordinates and information. | ||
| var places = { |
| @@ -21,11 +21,10 @@ | |||
| map.getSource('drone').setData(url); | |||
| }, 2000); | |||
|
|
|||
| map.addSource('drone', { type: 'geojson', data: url }); | |||
There was a problem hiding this comment.
This example uses map.getSource(...). I think it's clearer with the explicitly parallel addSource.
| @@ -136,11 +136,6 @@ | |||
| }); | |||
|
|
|||
| map.on('load', function() { | |||
| // Add a GeoJSON source containing place coordinates and information. | |||
| map.addSource("places", { | |||
There was a problem hiding this comment.
This example adds multiple layers using this source; keep the explicit addSource.
| @@ -33,17 +33,16 @@ | |||
| // After the map style has loaded on the page, add a source layer and default | |||
| // styling for a single point. | |||
| map.on('load', function() { | |||
| map.addSource('single-point', { | |||
There was a problem hiding this comment.
Keep, for parallelism with getSource.
| map.addLayer({ | ||
| "id": "highlight", | ||
| "type": "fill", | ||
| "source": "boroughs", | ||
| "source":{ |
| map.addLayer({ | ||
| "id": "point", | ||
| "type": "circle", | ||
| "source": "point", | ||
| "source":{ |
|
thanks for the quick review @jfirebaugh . changes are in. |
jfirebaugh
approved these changes
Jan 6, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating gl-js examples to reflect #3861. Mostly involves replacing
map.addSource(), with declaring the source explicitly withinaddLayer(). However, we're currently holding off on changing sources to which multiple layers refer.cc/ @lucaswoj @jfirebaugh